Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some spaghetti on PlayAnimationSongEvent #2308

Merged
merged 1 commit into from
May 8, 2024
Merged

Fix some spaghetti on PlayAnimationSongEvent #2308

merged 1 commit into from
May 8, 2024

Conversation

Burgerballs
Copy link
Contributor

No description provided.

trayfellow
trayfellow approved these changes May 8, 2024
View reviewed changes
Copy link

@trayfellow trayfellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my god 😭

@Burgerballs Burgerballs changed the base branch from main to develop May 8, 2024 05:58
BlueColorsin
BlueColorsin approved these changes May 8, 2024
View reviewed changes
Copy link

@BlueColorsin BlueColorsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh god why was it done like that 😭

EliteMasterEric
EliteMasterEric approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@EliteMasterEric EliteMasterEric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must have been really tired when I wrote this (or maybe I just forgot the syntax for multiple pattern matching lol).

sonic-boom-knuckles

@EliteMasterEric EliteMasterEric merged commit 6742e5c into FunkinCrew:develop May 8, 2024
@Burgerballs Burgerballs deleted the patch-1 branch May 8, 2024 06:41
@EliteMasterEric
Copy link
Member

Turns out that you got the syntax for this wrong! It's | and not ||. Did you make this change through the website?

I thought for sure that would work too but apparently not.

@Burgerballs
Copy link
Contributor Author

Turns out that you got the syntax for this wrong! It's | and not ||. Did you make this change through the website?

I thought for sure that would work too but apparently not.

this is a big whoopsie i must explode into several tiny versions of me and run aimlessly like that super mario 3d world boss

@ninjamuffin99 ninjamuffin99 added this to the 0.3.3 milestone May 9, 2024
@Hundrec Hundrec added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: optimization Involves a performance issue or a bug which causes lag. size: small A small pull request with 10 or fewer changes. pr: haxe PR modifies game code. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EliteMasterEric EliteMasterEric EliteMasterEric approved these changes

@trayfellow trayfellow trayfellow approved these changes

@BlueColorsin BlueColorsin BlueColorsin approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: optimization Involves a performance issue or a bug which causes lag.
Projects
None yet
Milestone
0.3.3
Development

Successfully merging this pull request may close these issues.
6 participants
@Burgerballs @EliteMasterEric @trayfellow @BlueColorsin @ninjamuffin99 @Hundrec