Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix focuscamera CLASSIC breaking zooms and snapping #2331

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

nebulazorua
Copy link
Contributor

When using Classic on FocusCamera, you have to place any zooms AFTER it, because it breaks them. It also snaps the camera, creating for jerky movement when having to use many Classic camera movements
This fixes that behaviour

@nebulazorua nebulazorua changed the base branch from main to develop May 8, 2024 20:56
@nebulazorua
Copy link
Contributor Author

might update to add "Reset Camera" to the Focus Camera event schema.
You might also want tweens to not reset for fast camera focuses, too, to prevent jerky movements.

@nebulazorua
Copy link
Contributor Author

nevermind tweens dont even call Reset Camera until after the tween is done unless its instant what the FUUCK
classic seems like it was just an oversight more than anything, then??
Still noticed an error though, so gonna fix that rq

@nebulazorua
Copy link
Contributor Author

hopefully should be fixed now

@EliteMasterEric
Copy link
Member

Me and Fabs reviewed this and concluded that the camera zooms work fine without this change. If you want to post the chart you're using and a before/after then that would help with review.

@EliteMasterEric EliteMasterEric self-assigned this May 29, 2024
@EliteMasterEric EliteMasterEric added the status: needs clarification Requires more info from the author. label May 29, 2024
@nebulazorua
Copy link
Contributor Author

Me and Fabs reviewed this and concluded that the camera zooms work fine without this change. If you want to post the chart you're using and a before/after then that would help with review.

Oh yeah hold on lemme get a video of it
I was running into the issue when porting B-Sides Stress

@nebulazorua
Copy link
Contributor Author

nebulazorua commented May 31, 2024

2024-05-31.18-23-59.mp4

As the camera switching becomes faster, you can see it snap. It looks really bad, imo, and forces me to use an ease style when I'd want to use classic.

And here's the after:

2024-05-31.18-30-49.mp4

@nebulazorua
Copy link
Contributor Author

nebulazorua commented May 31, 2024

OH YEAH also fixes a bug where camera focuses cancel camera zooms, like this (just a test on DadBattle)

Before:

2024-05-31.18-35-09.mp4

After:

2024-05-31.18-34-32.mp4

(Also shows the Classic snap)
Chart:
dadbattle-chart.json

@PurSnake
Copy link
Contributor

PurSnake commented Jun 9, 2024

Maybe it's time for a merge?
It was long enough that I didn’t even find it when I made my fix

@EliteMasterEric EliteMasterEric removed their assignment Jun 17, 2024
@EliteMasterEric EliteMasterEric added type: minor bug Involves a minor bug or issue. size: small A small pull request with 10 or fewer changes. labels Jul 11, 2024
@EliteMasterEric EliteMasterEric deleted the branch FunkinCrew:develop July 12, 2024 00:59
@nebulazorua
Copy link
Contributor Author

(Coming back to this to point out the issue this fixes can be seen in 0.5.0 with Erect Cocoa!)

Copy link
Contributor

@anysad anysad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cocoa Erect camera snapping hurts my brain lol

@EliteMasterEric EliteMasterEric removed the status: pending triage Awaiting review. label Sep 22, 2024
@EliteMasterEric EliteMasterEric added the status: needs clarification Requires more info from the author. label Sep 22, 2024
@EliteMasterEric EliteMasterEric self-assigned this Sep 22, 2024
@EliteMasterEric
Copy link
Member

Can you update the merge conflicts on this branch? @nebulazorua

@EliteMasterEric EliteMasterEric added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: needs clarification Requires more info from the author. labels Sep 25, 2024
@EliteMasterEric EliteMasterEric added this to the 0.5.1 milestone Sep 25, 2024
@Hundrec
Copy link
Collaborator

Hundrec commented Sep 26, 2024

Very good PR, needs to be conflict resolved immediately

@ninjamuffin99 ninjamuffin99 merged commit 998bbb2 into FunkinCrew:develop Sep 30, 2024
@Hundrec Hundrec added the pr: haxe PR modifies game code. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants