-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix focuscamera CLASSIC breaking zooms and snapping #2331
Conversation
might update to add "Reset Camera" to the Focus Camera event schema. |
nevermind tweens dont even call Reset Camera until after the tween is done unless its instant what the FUUCK |
…ween to classic should be fixed now?
hopefully should be fixed now |
Me and Fabs reviewed this and concluded that the camera zooms work fine without this change. If you want to post the chart you're using and a before/after then that would help with review. |
Oh yeah hold on lemme get a video of it |
2024-05-31.18-23-59.mp4As the camera switching becomes faster, you can see it snap. It looks really bad, imo, and forces me to use an ease style when I'd want to use classic. And here's the after: 2024-05-31.18-30-49.mp4 |
OH YEAH also fixes a bug where camera focuses cancel camera zooms, like this (just a test on DadBattle) Before: 2024-05-31.18-35-09.mp4After: 2024-05-31.18-34-32.mp4(Also shows the Classic snap) |
Maybe it's time for a merge? |
(Coming back to this to point out the issue this fixes can be seen in 0.5.0 with Erect Cocoa!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cocoa Erect camera snapping hurts my brain lol
Can you update the merge conflicts on this branch? @nebulazorua |
Very good PR, needs to be conflict resolved immediately |
When using Classic on FocusCamera, you have to place any zooms AFTER it, because it breaks them. It also snaps the camera, creating for jerky movement when having to use many Classic camera movements
This fixes that behaviour