Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character selection fix for chart editor #2370

Merged
merged 1 commit into from
May 9, 2024

Conversation

MadBear422
Copy link
Contributor

@MadBear422 MadBear422 commented May 8, 2024

image
This corrects an issue within the character dropdown grid of the chart editor, where the user cannot select them because of the previous hitbox width of the grid. Mention of this bug is found here: #2279
image
With this change it makes these characters selectable. No issues known so far

@EliteMasterEric
Copy link
Member

We were trying to figure this one out for ages, I thought for sure it was HaxeUI's fault.

Thanks for the PR. We will review and report back.

@Pietrodjaowjao
Copy link

It's bad that we cant compile to test.

@EliteMasterEric EliteMasterEric changed the base branch from main to develop May 9, 2024 03:02
@EliteMasterEric EliteMasterEric self-requested a review May 9, 2024 03:08
Copy link
Member

@EliteMasterEric EliteMasterEric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked great! Tested on stream.

@EliteMasterEric EliteMasterEric merged commit e3ee68a into FunkinCrew:develop May 9, 2024
@ninjamuffin99 ninjamuffin99 added this to the 0.3.3 milestone May 9, 2024
@Hundrec Hundrec added type: minor bug Involves a minor bug or issue. topic: chart editor Related to the operation of the Chart Editor. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. size: small A small pull request with 10 or fewer changes. pr: haxe PR modifies game code. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: chart editor Related to the operation of the Chart Editor. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants