Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OR operator instead of Array.contains() in BaseCharacter #2493

Merged
merged 4 commits into from
May 17, 2024
Merged

Use OR operator instead of Array.contains() in BaseCharacter #2493

merged 4 commits into from
May 17, 2024

Conversation

richTrash21
Copy link
Contributor

No description provided.

@EliteMasterEric EliteMasterEric merged commit 6e5783c into FunkinCrew:develop May 17, 2024
@EliteMasterEric
Copy link
Member

Good optimization

@richTrash21 richTrash21 deleted the develop-char-opt branch May 18, 2024 09:03
superpowers04 pushed a commit to superpowers04/Super-Funkin that referenced this pull request May 18, 2024
@EliteMasterEric @superpowers04
Merge pull request FunkinCrew#2493 from richTrash21/develop-char-opt
a4e8bf8 
Use OR operator instead of Array.contains() in BaseCharacter
@EliteMasterEric EliteMasterEric added this to the 0.4.0 milestone Jun 7, 2024
@Hundrec Hundrec added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: optimization Involves a performance issue or a bug which causes lag. size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EliteMasterEric EliteMasterEric EliteMasterEric approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: optimization Involves a performance issue or a bug which causes lag.
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@richTrash21 @EliteMasterEric @Hundrec @ninjamuffin99