Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consistent flashing #2494

Merged
merged 3 commits into from
Sep 16, 2024
Merged

consistent flashing #2494

merged 3 commits into from
Sep 16, 2024

Conversation

cyn0x8
Copy link
Contributor

@cyn0x8 cyn0x8 commented May 13, 2024 •
edited
Loading

minor improvement - more accurate flashing behavior for menu stuff

when you work out the existing math the flashes usually happen at around 0.05 sec or 20fps, but not always...
image

this change should make it consistent 20fps across any framerate (over 20fps at least, under 20 itll flash every frame)

@ninjamuffin99 ninjamuffin99 added the status: needs clarification Requires more info from the author. label May 15, 2024
@cyn0x8
Copy link
Contributor Author

cyn0x8 commented Jun 4, 2024

before:

2024-06-04.13-55-46.mp4

after:

2024-06-04.13-56-23.mp4

the difference is smaller on higher fps since the error becomes smaller (see graph), this pr is just for accuracy

Untitled.video.-.Made.with.Clipchamp.6.mp4

@EliteMasterEric EliteMasterEric self-requested a review June 8, 2024 01:28
@EliteMasterEric EliteMasterEric added reviewing-internally and removed status: needs clarification Requires more info from the author. labels Jun 8, 2024
@EliteMasterEric EliteMasterEric added status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature. topic: polish Involves minor polish to the UI or gameplay. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed reviewing-internally status: pending triage Awaiting review. labels Jun 16, 2024
@EliteMasterEric EliteMasterEric self-assigned this Jul 10, 2024
@EliteMasterEric EliteMasterEric added size: small A small pull request with 10 or fewer changes. size: medium A medium pull request with 100 or fewer changes. and removed size: small A small pull request with 10 or fewer changes. labels Jul 11, 2024
@EliteMasterEric EliteMasterEric deleted the branch FunkinCrew:develop July 12, 2024 00:59
@EliteMasterEric EliteMasterEric added this to the 0.5.0 milestone Jul 12, 2024
@EliteMasterEric EliteMasterEric merged commit ea2e650 into FunkinCrew:develop Sep 16, 2024
@cyn0x8 cyn0x8 deleted the flash_fix branch October 9, 2024 22:19
@Hundrec Hundrec added the pr: haxe PR modifies game code. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EliteMasterEric EliteMasterEric EliteMasterEric approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: polish Involves minor polish to the UI or gameplay. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cyn0x8 @EliteMasterEric @ninjamuffin99 @Hundrec