-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Charting Editor Sustain Trails (2 bugs) #2565
[BUGFIX] Charting Editor Sustain Trails (2 bugs) #2565
Conversation
i got one of these problems before, tysm |
the Incorrect Sustain Trails origin note has actually been bothering me for a while, this is cool :) |
Approving because this does fix stuff, but currently Downscroll on chart editor doesn't fully work as intended (It's supposed to flip the note grid vertically and scroll upwards, I never properly implemented that which is why it's grayed out in the editor). |
Options downscroll and charting downscroll are separated things, the bug is related to options downscroll, a different check should be in ChartEditorHoldNoteSprite for charting downscroll. Should anyways revert it so at least the other fix gets merged? |
Ah that explains it! We can leave |
This pull request fixes two bugs:
Note Sustain Trails getting cut/inverted when is downscroll enabled
Incorrect Sustain Trails origin note (based on ghost note)
Recording.2024-05-20.015437.mp4
Recording.2024-05-20.020011.mp4
Hope this gets added soon =D