Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Custom Note Style Support #2581

Merged
merged 1 commit into from
May 24, 2024
Merged

[FEATURE] Custom Note Style Support #2581

merged 1 commit into from
May 24, 2024

Conversation

Keoiki
Copy link
Contributor

@Keoiki Keoiki commented May 21, 2024 •
edited
Loading

The Funkin' devs did an oopsie and hardcoded note styles in songs and the chart editor.

  • Songs now use the note style provided in the respective variation's metadata file.
  • The Note Styles dropdown menu in the Chart Editor now properly populates with entries from the NoteStyleRegistery. (It had a function all along but they forgot to use it lol)

Consired merging FunkinCrew/funkin.assets#8 into the assets repo as it fixes Week 6 Erect songs having the wrong note style as a result of this change.

@Keoiki Keoiki mentioned this pull request May 21, 2024
Closed
@EliteMasterEric EliteMasterEric self-assigned this May 21, 2024
@EliteMasterEric EliteMasterEric changed the title Note Style softcoding [FEATURE] Custom Note Style Support May 22, 2024
EliteMasterEric
EliteMasterEric approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@EliteMasterEric EliteMasterEric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great when I tested!

@EliteMasterEric EliteMasterEric merged commit b6724eb into FunkinCrew:develop May 24, 2024
@Keoiki Keoiki deleted the playstate-notestyles-query branch June 4, 2024 23:24
@gamerbross
Copy link
Contributor

FunkinCrew/funkin.assets#8 didn't got merged and now the week 6 erects note styles are broken 😭

@EliteMasterEric EliteMasterEric added this to the 0.4.0 milestone Jun 7, 2024
@Hundrec Hundrec added type: enhancement Involves an enhancement or new feature. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. size: small A small pull request with 10 or fewer changes. pr: haxe PR modifies game code. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EliteMasterEric EliteMasterEric EliteMasterEric approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Keoiki @gamerbross @EliteMasterEric @Hundrec