[BUGFIX] Fixed memory counter displaying negative numbers #2713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tposejank
approved these changes
Jun 9, 2024
EliteMasterEric
added
status: pending triage
EliteMasterEric
added
the
size: small
EliteMasterEric
approved these changes
Jul 11, 2024
EliteMasterEric
added
status: accepted
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the Gc memory usage exceeds what's around 2GB, the memory counter dies and display negative numbers which is due to the limit of Int32
(Note for testing: easiest way to achieve this is by going through every stage in the game)
now the bytes are retrieved as a Float (on cpp targets only) so the memory counter will likely never show negative mem usage (unless you're playing on a nasa PC and got a huge memory leak lol?)