Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] When pressing chart key while charting, chart gets reset #2739

Merged
merged 2 commits into from
Sep 16, 2024
Merged

[BUGFIX] When pressing chart key while charting, chart gets reset #2739

merged 2 commits into from
Sep 16, 2024

Conversation

gamerbross
Copy link
Contributor

(Wasn't this already fixed?)

@gamerbross gamerbross changed the base branch from main to develop June 10, 2024 14:55
@nebulazorua
Copy link
Contributor

this WAS fixed, but a PR of mine accidentally reverted the change
whoopsie!

@Matriculaso
Copy link

this WAS fixed, but a PR of mine accidentally reverted the change whoopsie!

pendejo

trayfellow
trayfellow approved these changes Jun 13, 2024
View reviewed changes
Copy link

@trayfellow trayfellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pain

@EliteMasterEric EliteMasterEric added the status: pending triage Awaiting review. label Jun 17, 2024
@EliteMasterEric EliteMasterEric self-assigned this Jun 17, 2024
@EliteMasterEric EliteMasterEric added type: minor bug Involves a minor bug or issue. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. labels Jun 17, 2024
@EliteMasterEric
Copy link
Member

this WAS fixed, but a PR of mine accidentally reverted the change whoopsie!

Ah, that makes sense!

PR approved we will get it merged shortly.

@EliteMasterEric EliteMasterEric removed their assignment Jun 17, 2024
@EliteMasterEric EliteMasterEric added the topic: chart editor Related to the operation of the Chart Editor. label Jun 27, 2024
@EliteMasterEric EliteMasterEric self-assigned this Jul 10, 2024
@EliteMasterEric EliteMasterEric added the size: small A small pull request with 10 or fewer changes. label Jul 10, 2024
@EliteMasterEric EliteMasterEric deleted the branch FunkinCrew:develop July 12, 2024 01:00
@EliteMasterEric EliteMasterEric added this to the 0.5.0 milestone Jul 12, 2024
@EliteMasterEric EliteMasterEric merged commit 724c415 into FunkinCrew:develop Sep 16, 2024
@gamerbross gamerbross deleted the bugfix/chart-key branch September 25, 2024 22:52
@Hundrec Hundrec added the pr: haxe PR modifies game code. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trayfellow trayfellow trayfellow approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: chart editor Related to the operation of the Chart Editor. type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
6 participants
@gamerbross @nebulazorua @Matriculaso @EliteMasterEric @trayfellow @Hundrec