[BUGFIX] Default health icon (face) not used #3005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EliteMasterEric
added
type: minor bug
|
gamerbross ur so goated |
EliteMasterEric
added
status: accepted
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the icon file wasn't found, the icon shows as HaxeFlixel logo instead of
face. It was supposed to call the loadCharacter in the setter ofcharacterIdbut was later changed and not working as intended.I changed some other code that was using BF icon as default instead of face. Also in the previous way of checking if the icon exists, it was did twice, leading into a possible stack overflow (which don't show a log) if also the
faceicon image doesn't exist.