-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIXES CHARACTER PATH ONLY CHECKING IN SHARED #3035
FIXES CHARACTER PATH ONLY CHECKING IN SHARED #3035
Conversation
I don't think this is a good idea since I don't think it checks in shared by default |
why not just place character assets in |
it doesn't check in |
I know, that's kinda why I think this might cause issues |
why tho? |
i want to add the characters in a week type dir to save memory and just to make images look cleaner |
how would it be an issue? it checks first for preload, then for the level path, and then shared |
Paths automatically checks which library has the file before using it, so this should be good. I believe characters were originally IN the level folders before moving them out due to issues when characters were shared between levels. |
@EliteMasterEric so this may or may not have broken how animate atlas characters work, since paths for animate atlases uses getLib path and now that's it's null it ONLY checks in preload, and before that it only checked in shared, you should make it so the paths.animateAtlas takes the path and checks for its animate json file by normal getPath and then make it go back a few to the folder |
I don't understand what you mean, if this breaks things then Blazin' would be unplayable. |
The characters in blazin' put "shared:" in the start of the path; but mods that don't before it would work for them and now their characters are broken |
kinda not a problem though? in normal flixel projects you already get assets from libraries in that way |
so im trying to make it so it will load characters from a week dir but its not letting me so i checked and saw this was the problem so i fixed it :3