Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIXES CHARACTER PATH ONLY CHECKING IN SHARED #3035

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

7oltan
Copy link
Contributor

@7oltan 7oltan commented Jul 16, 2024

so im trying to make it so it will load characters from a week dir but its not letting me so i checked and saw this was the problem so i fixed it :3

@moxie-coder
Copy link

I don't think this is a good idea since I don't think it checks in shared by default

@anysad
Copy link
Contributor

anysad commented Jul 16, 2024

why not just place character assets in shared/images/characters?

@anysad
Copy link
Contributor

anysad commented Jul 16, 2024

I don't think this is a good idea since I don't think it checks in shared by default

it doesn't check in shared by default, it initially checks in preload

@moxie-coder
Copy link

I don't think this is a good idea since I don't think it checks in shared by default

it doesn't check in shared by default, it initially checks in preload

I know, that's kinda why I think this might cause issues

@7oltan
Copy link
Contributor Author

7oltan commented Jul 16, 2024

I don't think this is a good idea since I don't think it checks in shared by default

it doesn't check in shared by default, it initially checks in preload

I know, that's kinda why I think this might cause issues

why tho?

@7oltan
Copy link
Contributor Author

7oltan commented Jul 16, 2024

why not just place character assets in shared/images/characters?

i want to add the characters in a week type dir to save memory and just to make images look cleaner

@EliteMasterEric EliteMasterEric added the status: pending triage Awaiting review. label Jul 17, 2024
@mayo78
Copy link

mayo78 commented Jul 18, 2024

I don't think this is a good idea since I don't think it checks in shared by default

it doesn't check in shared by default, it initially checks in preload

I know, that's kinda why I think this might cause issues

how would it be an issue? it checks first for preload, then for the level path, and then shared

@EliteMasterEric EliteMasterEric added status: reviewing internally Under consideration and testing. type: optimization Involves a performance issue or a bug which causes lag. and removed status: pending triage Awaiting review. labels Jul 23, 2024
@EliteMasterEric EliteMasterEric self-assigned this Jul 23, 2024
@EliteMasterEric EliteMasterEric added the size: small A small pull request with 10 or fewer changes. label Jul 23, 2024
@EliteMasterEric
Copy link
Member

Paths automatically checks which library has the file before using it, so this should be good.

I believe characters were originally IN the level folders before moving them out due to issues when characters were shared between levels.

@EliteMasterEric EliteMasterEric added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally Under consideration and testing. labels Jul 29, 2024
@EliteMasterEric EliteMasterEric added this to the 0.5.0 milestone Jul 29, 2024
@EliteMasterEric EliteMasterEric changed the base branch from main to develop September 16, 2024 21:57
@EliteMasterEric EliteMasterEric merged commit 57523c9 into FunkinCrew:develop Sep 16, 2024
@7oltan
Copy link
Contributor Author

7oltan commented Dec 16, 2024

@EliteMasterEric so this may or may not have broken how animate atlas characters work, since paths for animate atlases uses getLib path and now that's it's null it ONLY checks in preload, and before that it only checked in shared, you should make it so the paths.animateAtlas takes the path and checks for its animate json file by normal getPath and then make it go back a few to the folder

@EliteMasterEric
Copy link
Member

@EliteMasterEric so this may or may not have broken how animate atlas characters work, since paths for animate atlases uses getLib path and now that's it's null it ONLY checks in preload, and before that it only checked in shared, you should make it so the paths.animateAtlas takes the path and checks for its animate json file by normal getPath and then make it go back a few to the folder

I don't understand what you mean, if this breaks things then Blazin' would be unplayable.

@7oltan
Copy link
Contributor Author

7oltan commented Dec 19, 2024

@EliteMasterEric so this may or may not have broken how animate atlas characters work, since paths for animate atlases uses getLib path and now that's it's null it ONLY checks in preload, and before that it only checked in shared, you should make it so the paths.animateAtlas takes the path and checks for its animate json file by normal getPath and then make it go back a few to the folder

I don't understand what you mean, if this breaks things then Blazin' would be unplayable.

The characters in blazin' put "shared:" in the start of the path; but mods that don't before it would work for them and now their characters are broken image

@mayo78
Copy link

mayo78 commented Dec 23, 2024

kinda not a problem though? in normal flixel projects you already get assets from libraries in that way

@Hundrec Hundrec added the pr: haxe PR modifies game code. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: optimization Involves a performance issue or a bug which causes lag.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants