[BUGFIX] Chart Editor: Implement Animated Pixel Icons #3339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TechnikTil
changed the title
JVNpixels
approved these changes
Sep 17, 2024
TechnikTil
changed the title
|
I just can’t let go of this pr for some reason lol |
TechnikTil
changed the title
|
Works 👍 |
EliteMasterEric
added
type: minor bug
|
My life has been completed. I committed to the Funkin repository, and it wasn't a typo. I officially have 100%'d life. |
|
Also I was gonna implement animations but ok lol |
|
It makes more sense to just keep them on the first frame, as adding animations complicates the code for the interface and could cause things to break |
|
yk what good point |
|
ok im finished now. |
TechnikTil
commented
Sep 19, 2024
2 tasks
…ound, and fix some stuff cuz i dumb (this is the last push i swear)
|
Not sure why Github doesn't like this PR but it did get merged. |
GitHub didn’t like it because I updated the branch AFTER you merged. (Sorry I kept having 4:35AM cravings) also I just noticed this comment lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
#3299 #3222 #3148 (might be more, idk)
Briefly describe the issue(s) fixed.
This PR fixes Animated Pixel Icons showing their spritesheets by extracting the first frame of their idle from them. This is all done in-game to simplify implementation, and save storage space.
Include any relevant screenshots or videos.
Before:
After:
(dont mind my fps)
"TODO":