Fix Pico's songs not appearing on Freeplay #3506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninjamuffin99
changed the title
ninjamuffin99
force-pushed
the
develop
branch
2 times, most recently
from
e0b1b01 to
410cfe9
Compare
ninjamuffin99
force-pushed
the
pico-menu-fix
branch
2 times, most recently
from
5e8590b to
38de7c1
Compare
EliteMasterEric
approved these changes
Oct 4, 2024
EliteMasterEric
added
type: major bug
Previously the game would load variations in a `variation-difficulty` string format, but now we map it out better and filter it based on that, rather than messing around with suffixes and whatnot. If you have a mod that depended on the functionality of the `variation-difficulty` format, you should accomodate that functionality in another way re-add freeplay song preview song names and icons implemented again implement the scoring rank, bpm, and difficulty crud albumId loading fix
…ng()` to allow usage of the function by inputting a variation id
…multiple variations/difficulty input freeplay implement for NEW song stuff w/ assets submod save data crap and crud rank icon fixes for fixed pico menu
ninjamuffin99
force-pushed
the
pico-menu-fix
branch
from
38de7c1 to
d2e2987
Compare
|
thanks ninja muffin, you da goat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Freeplay would default it's difficulty string to
normalbut pico variations arenormal-pico, so it wouldn't show you any Pico remix songs until you went to Random and changed difficulties.This just initializes the suffixed difficulty string with
-pico(or any other non-bf character id) when we load up Freeplay, so the initial generateSongs() filters correctly