Fixed bug that makes the whole game crash at the start of week 6 #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GOOD ENUF PROBABLY |
kudorado
pushed a commit
to kudorado/Funkin
that referenced
this pull request
Jul 18, 2021
Fixed bug that makes the whole game crash at the start of week 6
ninjamuffin99
added a commit
that referenced
this pull request
Mar 9, 2023
Fixed bug that makes the whole game crash at the start of week 6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, if you start hitting any key while senpai starts speaking at the start of the week the game will crash because is not fast enough to get the dialogue info before going to the next line:
Here's the output:
I worked around it by having to check if the dialoglist array has any info before triggering anything else