Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Remove Flicker When Accepting FPS Setting #3629

Merged
merged 1 commit into from
Oct 10, 2024
Merged

[FIX] Remove Flicker When Accepting FPS Setting #3629

merged 1 commit into from
Oct 10, 2024

Conversation

lemz1
Copy link
Contributor

@lemz1 lemz1 commented Oct 9, 2024

FIXES

fixes #3624

CHANGES

this pr sets fireInstantly to true for Enum and Number preference items.
this fixes the issue with the flicker.

@github-actions github-actions bot added size: large A large pull request with more than 100 changes. pr: haxe PR modifies game code. pr: documentation PR modifies documentation or README files. and removed size: large A large pull request with more than 100 changes. labels Oct 9, 2024
@lemz1 lemz1 changed the base branch from main to develop October 9, 2024 18:52
@github-actions github-actions bot added the size: small A small pull request with 10 or fewer changes. label Oct 9, 2024
JVNpixels
JVNpixels approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@JVNpixels JVNpixels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job bro, speedy fast too!

AbnormalPoof
AbnormalPoof approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@AbnormalPoof AbnormalPoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done

@ninjamuffin99 ninjamuffin99 merged commit b2647fe into FunkinCrew:develop Oct 10, 2024
2 checks passed
@ninjamuffin99
Copy link
Member

very nice thank you very much :)

@EliteMasterEric EliteMasterEric added this to the 0.5.2 milestone Oct 12, 2024
@Hundrec Hundrec added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: minor bug Involves a minor bug or issue. and removed pr: documentation PR modifies documentation or README files. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotHyper-474 NotHyper-474 NotHyper-474 approved these changes

@charlesisfeline charlesisfeline charlesisfeline approved these changes

@AbnormalPoof AbnormalPoof AbnormalPoof approved these changes

@JVNpixels JVNpixels JVNpixels approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
0.5.2
Development

Successfully merging this pull request may close these issues.

Bug Report: FPS Option is able to be flickered/selected.
8 participants
@lemz1 @ninjamuffin99 @NotHyper-474 @charlesisfeline @AbnormalPoof @JVNpixels @EliteMasterEric @Hundrec