Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pixel-style note hold trails being too small #10

Closed
wants to merge 1 commit into from

Conversation

AbnormalPoof
Copy link
Collaborator

The pixel-style note trails appear small as of the WeekEnd 1 update. This PR aims to adjust it to how it was before.

Before:
Screenshot 2024-05-22 at 5 54 51 PM

After:
Screenshot 2024-05-22 at 5 54 27 PM

Copy link

@trayfellow trayfellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

danny-devito-its-always-sunny(1)

@D4rkJony
Copy link

Tiny complaint here, but I think it's a little bit off-center. I think you should move the note trail a few pixels to the left to center it.

@AbnormalPoof
Copy link
Collaborator Author

I'm not really able to do anything about that, unfortunately. I only modified the scaling.

@D4rkJony
Copy link

Oh ok, it's still way better than it was before, I hope the devs actually fix the note trail being off-center though.

@AbnormalPoof AbnormalPoof changed the title Fix Pixel trails being too small Fix Pixel-style note hold trails being too small Jun 17, 2024
@EliteMasterEric EliteMasterEric added the status: pending triage The bug or PR has not been reviewed yet. label Jul 9, 2024
@AbnormalPoof
Copy link
Collaborator Author

Superseded by Funkin#3351 which is honestly a much better fix.

@AbnormalPoof AbnormalPoof deleted the patch-1 branch September 27, 2024 13:04
@AbnormalPoof
Copy link
Collaborator Author

AbnormalPoof commented Sep 30, 2024

Looks like it was merged internally for 0.5.1!
IMG_0172
(This was replaced though when Funkin#3351 was merged.)

@EliteMasterEric EliteMasterEric added status: rejected PR did not pass review or cannot be approved. and removed status: pending triage The bug or PR has not been reviewed yet. labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: rejected PR did not pass review or cannot be approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants