This repository was archived by the owner on Oct 21, 2022. It is now read-only.
Bug fix: crash when viewing 'mature content' without login #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* github actions: using `npm i` for android build * fix repository settings in package.json
When not login, server will only return object `data.errorinfo`, no more extra elements.
celeron533
commented
Feb 19, 2022
| @@ -18,9 +18,9 @@ const ArtDetail = (props) => { | |||
| return <div className='art-detail-page'> | |||
| <TitleBar /> | |||
| {isViewerDisplay && <WxImageViewer onClose={() => setDisplay(false)} urls={[picSrc]} index={0}/>} | |||
| <img className='art-preview' onClick={() => setDisplay(true)} src={picSrc} /> | |||
There was a problem hiding this comment.
图片永远都能成功读取，不论是不是mature
celeron533
commented
Feb 19, 2022
| isLoading || <> | ||
| {!isLoading && data.success === true && <> | ||
| <img className='art-preview' onClick={() => setDisplay(true)} src={picSrc} /> | ||
|
|
||
| <div className="art-info-title">{data.artwork.title}</div> |
There was a problem hiding this comment.
如果本次entry时mature，data仅有内容：
'success' : true,
'errorinfo' : 'Please login ......'
无 data.artwork ，导致整个页面/android app 炸掉
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the crash when viewing 'mature content' without login
When not login, server will only return object
data.errorinfo, no more extra elements.前端萌新，react不熟。