Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center the announcement #32

Merged
merged 2 commits into from
Jan 5, 2022
Merged

Center the announcement #32

merged 2 commits into from
Jan 5, 2022

Conversation

im-coder-lg
Copy link
Member

I'd like to know the difference between a normal announcement(btw @sumeshir26 great that you did that!) and the one I modified. I used the <div> HTML tag and aligned it to the center(<div align=center>) so anything that you type there will be centred. The extra enters are to allow the MD tags, want to know if this is worth being on the main branch.
PS: Some realigning is needed in the README, maybe I could do it now in this PR. Also maybe I'll consider merging both the <img> tag and the banner together.

@im-coder-lg im-coder-lg self-assigned this Jan 4, 2022
@not-nef
Copy link
Member

not-nef commented Jan 4, 2022

i like this because i think the announcement should be the first thing you see imo

@im-coder-lg
Copy link
Member Author

A lil' bit more changes needed though. Will do that soon.

@im-coder-lg
Copy link
Member Author

I'm done! What do you think?

Copy link
Member

@not-nef not-nef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put the announcement under the title, how it was before. but if you think this is better, i approve

@im-coder-lg
Copy link
Member Author

Hmm, do people really read the Readme? I think half would need a quick abstract of the project, so that's why I kept it on the top, nvm need @sumeshir26's review on this. But my initial idea was to make users know that v0.9 is out and users can get it by visiting the link given, so what do you think about my idea?

@not-nef
Copy link
Member

not-nef commented Jan 4, 2022

Well i do read the readme, to see if the project interests me. But ok.

@im-coder-lg
Copy link
Member Author

Well i do read the readme, to see if the project interests me. But ok.

I was thinking from a novice user's perspective. They'd want a quick install, so I prioritised that.

@im-coder-lg
Copy link
Member Author

Squash and merge? Might be better.

@sumeshir26 sumeshir26 merged commit 7a626f6 into master Jan 5, 2022
@sumeshir26 sumeshir26 deleted the readme-improvement branch January 5, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants