Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize communication barriers #1120

Merged
merged 3 commits into from
Oct 21, 2021
Merged

Conversation

rmontuoro
Copy link
Contributor

Description

This PR starts to implement changes discussed in issue #1118 with the purpose of eliminating unnecessary communication barriers to attempt improving runtime performance of MAPL-based applications.

Related Issue

See issue #1118.

Motivation and Context

Improving runtime performance of MAPL-based applications.

How Has This Been Tested?

These changes have been tested on NOAA platforms with Intel 18.0.5.274 and Intel MPI 2018.0.4.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@rmontuoro rmontuoro added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix labels Oct 21, 2021
@rmontuoro rmontuoro self-assigned this Oct 21, 2021
@rmontuoro rmontuoro requested a review from a team as a code owner October 21, 2021 16:54
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmontouro - If you have any performance numbers indicating a measurable difference, it would be nice to capture them here. Nothing fancy just a % change for this layer or UFS as a whole.

@tclune tclune merged commit f48d150 into develop Oct 21, 2021
@mathomp4 mathomp4 deleted the bugfix/rmontuoro/#1118-vm-barriers branch October 25, 2021 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants