Feature/acg extra rm brackets 1750 #3462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darianboggs
added
🎁 New Feature
tclune
previously approved these changes
Mar 4, 2025
|
The only change was resolving the conflict in CHANGELOG.md. |
tclune
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of change(s)
Checklist
make tests)Description
When a column in a StateSpecs file is array-valued, and the user mistakenly puts array brackets (
[and]) around the column value. The resulting include file is double brackets ([[and]]) which is wrong. This PR handles this more gracefully. With it, the column value can have array brackets, but they are not required. In the resulting include file, ACG writes a single set of array brackets. Because this problem has not been reported, I did not make it to ACG for MAPL2. It is worth correcting it in ACG3.Related Issue
#1750