Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes migrations for layers and maps #472

Merged
merged 2 commits into from
Oct 25, 2012
Merged

fixes migrations for layers and maps #472

merged 2 commits into from
Oct 25, 2012

Conversation

cspanring
Copy link
Contributor

Removes duplicates in layer migrations and adds a layer migration dependency to maps migrations. closes #471

@jj0hns0n jj0hns0n merged commit 5246b19 into GeoNode:dev Oct 25, 2012
@matthewhanson
Copy link
Member

I'm still getting an error when running migrate, though different column and model this time:

django.db.utils.DatabaseError: column "geographic_bounding_box" of relation "layers_layer" does not exist

@ischneider
Copy link
Member

does it make sense to collapse all the migrations into a single cumulative migration for each app, i.e. pre-dev -> dev?

@ingenieroariel
Copy link
Member

I second Ian's idea.

On Fri, Oct 26, 2012 at 1:14 PM, Ian Schneider [email protected]:

does it make sense to collapse all the migrations into a single cumulative
migration for each app, i.e. pre-dev -> dev?


Reply to this email directly or view it on GitHubhttps://github.com//pull/472#issuecomment-9820209.

@jj0hns0n
Copy link
Contributor

Fwiw, in mainline dev, the migrations are just not used anymore, they are
bypassed with a syncdb --all

Im also +1 on 'squashing' these down into a single migration from 1.2final
to 2.0alpha1 Not sure how we can best do that, but thats the best plan I
think.

On Fri, Oct 26, 2012 at 10:31 AM, Ariel Núñez [email protected]:

I second Ian's idea.

On Fri, Oct 26, 2012 at 1:14 PM, Ian Schneider [email protected]:

does it make sense to collapse all the migrations into a single
cumulative
migration for each app, i.e. pre-dev -> dev?


Reply to this email directly or view it on GitHub<
https://github.com/GeoNode/geonode/pull/472#issuecomment-9820209>.


Reply to this email directly or view it on GitHubhttps://github.com//pull/472#issuecomment-9820716.

@ingenieroariel
Copy link
Member

Jeff, just to clarify, I consider Ian's approach of one migration per app
to be better than just one single migration. They both have the same goal.

On Fri, Oct 26, 2012 at 1:37 PM, Jeffrey Johnson
[email protected]:

Fwiw, in mainline dev, the migrations are just not used anymore, they are
bypassed with a syncdb --all

Im also +1 on 'squashing' these down into a single migration from 1.2final
to 2.0alpha1 Not sure how we can best do that, but thats the best plan I
think.

On Fri, Oct 26, 2012 at 10:31 AM, Ariel Núñez [email protected]:

I second Ian's idea.

On Fri, Oct 26, 2012 at 1:14 PM, Ian Schneider [email protected]:

does it make sense to collapse all the migrations into a single
cumulative
migration for each app, i.e. pre-dev -> dev?


Reply to this email directly or view it on GitHub<
https://github.com/GeoNode/geonode/pull/472#issuecomment-9820209>.


Reply to this email directly or view it on GitHub<
https://github.com/GeoNode/geonode/pull/472#issuecomment-9820716>.


Reply to this email directly or view it on GitHubhttps://github.com//pull/472#issuecomment-9820914.

@matthewhanson
Copy link
Member

Migration per app seems like the best solution to me too.

Jeff - I can't find what the --all switch is supposed to do to syncdb, it does not appear in the django documentation.

@jj0hns0n
Copy link
Contributor

Thats what I mean. One per app, but one jump from 1.2 to 2.0 instead of
incremental.

On Fri, Oct 26, 2012 at 10:43 AM, Ariel Núñez [email protected]:

Jeff, just to clarify, I consider Ian's approach of one migration per app
to be better than just one single migration. They both have the same goal.

On Fri, Oct 26, 2012 at 1:37 PM, Jeffrey Johnson
[email protected]:

Fwiw, in mainline dev, the migrations are just not used anymore, they
are
bypassed with a syncdb --all

Im also +1 on 'squashing' these down into a single migration from
1.2final
to 2.0alpha1 Not sure how we can best do that, but thats the best plan I
think.

On Fri, Oct 26, 2012 at 10:31 AM, Ariel Núñez [email protected]:

I second Ian's idea.

On Fri, Oct 26, 2012 at 1:14 PM, Ian Schneider <
[email protected]>wrote:

does it make sense to collapse all the migrations into a single
cumulative
migration for each app, i.e. pre-dev -> dev?


Reply to this email directly or view it on GitHub<
https://github.com/GeoNode/geonode/pull/472#issuecomment-9820209>.


Reply to this email directly or view it on GitHub<
https://github.com/GeoNode/geonode/pull/472#issuecomment-9820716>.


Reply to this email directly or view it on GitHub<
https://github.com/GeoNode/geonode/pull/472#issuecomment-9820914>.


Reply to this email directly or view it on GitHubhttps://github.com//pull/472#issuecomment-9821096.

@jj0hns0n
Copy link
Contributor

Its just bypasses the migrations and does a normal syncdb as if you didnt
have south setup.

On Fri, Oct 26, 2012 at 10:47 AM, Matthew Hanson
[email protected]:

Migration per app seems like the best solution to me too.

Jeff - I can't find what the --all switch is supposed to do to syncdb, it
does not appear in the django documentation.


Reply to this email directly or view it on GitHubhttps://github.com//pull/472#issuecomment-9821183.

@ingenieroariel
Copy link
Member

But that did not help Jenkins succeed in running the tests, right? Do you
have any idea why?

On Fri, Oct 26, 2012 at 1:47 PM, Jeffrey Johnson
[email protected]:

Its just bypasses the migrations and does a normal syncdb as if you didnt
have south setup.

On Fri, Oct 26, 2012 at 10:47 AM, Matthew Hanson
[email protected]:

Migration per app seems like the best solution to me too.

Jeff - I can't find what the --all switch is supposed to do to syncdb,
it
does not appear in the django documentation.


Reply to this email directly or view it on GitHub<
https://github.com/GeoNode/geonode/pull/472#issuecomment-9821183>.


Reply to this email directly or view it on GitHubhttps://github.com//pull/472#issuecomment-9821205.

@jj0hns0n
Copy link
Contributor

I dont, something very strange up with jenkins. @ischneider and I both
logged into that machine and ran the tests in the same place and in the
same way that jenkins should be running them, and they pass. They only fail
when run this way. I will look into it eventually.

On Fri, Oct 26, 2012 at 10:49 AM, Ariel Núñez [email protected]:

But that did not help Jenkins succeed in running the tests, right? Do you
have any idea why?

On Fri, Oct 26, 2012 at 1:47 PM, Jeffrey Johnson
[email protected]:

Its just bypasses the migrations and does a normal syncdb as if you
didnt
have south setup.

On Fri, Oct 26, 2012 at 10:47 AM, Matthew Hanson
[email protected]:

Migration per app seems like the best solution to me too.

Jeff - I can't find what the --all switch is supposed to do to syncdb,
it
does not appear in the django documentation.


Reply to this email directly or view it on GitHub<
https://github.com/GeoNode/geonode/pull/472#issuecomment-9821183>.


Reply to this email directly or view it on GitHub<
https://github.com/GeoNode/geonode/pull/472#issuecomment-9821205>.


Reply to this email directly or view it on GitHubhttps://github.com//pull/472#issuecomment-9821262.

@cspanring
Copy link
Contributor Author

I could start working on one 1.2=>2.0 migration per app, if that's still the plan. Just let me know or create an issue for it.

@jj0hns0n
Copy link
Contributor

Im guessing that once @tomkralidis is finished with the modifications to
the ResourceBase class, we will have no more DB changes before the first
alpha, which means that it makes sense to start working on the migration.
Christian, it would be great if you could take the lead on this.

On Tue, Nov 27, 2012 at 8:11 AM, Christian Spanring <
[email protected]> wrote:

I could start working on one 1.2=>2.0 migration per app, if that's still
the plan. Just let me know or create an issue for it.


Reply to this email directly or view it on GitHubhttps://github.com//pull/472#issuecomment-10759068.

@capooti
Copy link
Member

capooti commented Dec 28, 2012

Hi all
this is a first attemp: capooti@ded2623
now I can succesfully migrate from 1.2 to latest dev branch. I will test it more deeply in the next days, and eventually collapse all the scripts in one script per app if this is the preferred way to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants