#87 add instance for time of day #196
Conversation
test/Data/Swagger/ParamSchemaSpec.hs
Outdated
| @@ -30,6 +34,7 @@ spec = do | |||
| context "Unary records" $ do | |||
| context "Email (unary record)" $ checkToParamSchema (Proxy :: Proxy Email) emailSchemaJSON | |||
| context "UserId (non-record newtype)" $ checkToParamSchema (Proxy :: Proxy UserId) userIdSchemaJSON | |||
| context "TimeOfDay" $ checkToParamSchema (Proxy :: Proxy TimeOfDay) (Object (HM.fromList [("format",String "hh:MM:ss"),("type",String "string")])) | |||
There was a problem hiding this comment.
Could you put schema's JSON value in SpecCommon, just like colorSchemaJSON and others?
test/Data/Swagger/SchemaSpec.hs
Outdated
| @@ -110,6 +115,7 @@ spec = do | |||
| context "MyRoseTree' (inlineNonRecursiveSchemas)" $ checkInlinedRecSchema (Proxy :: Proxy MyRoseTree') myRoseTreeSchemaJSON' | |||
| describe "Bounded Enum key mapping" $ do | |||
| context "ButtonImages" $ checkToSchema (Proxy :: Proxy ButtonImages) buttonImagesSchemaJSON | |||
| context "TimeOfDay" $ checkToSchema (Proxy :: Proxy TimeOfDay ) (Object (HM.fromList [("example",String "12:33:15"),("format",String "hh:MM:ss"),("type",String "string")])) | |||
There was a problem hiding this comment.
Could you put schema's JSON value in SpecCommon, just like colorSchemaJSON and others?
anneloreegger
changed the title
|
Are there any news on this issue? |
|
Could you please fix the merge conflict? I have commit authority here now and will make sure this gets merged once you have. Thanks! |
…_TimeOfDay # Conflicts: # test/Data/Swagger/SchemaSpec.hs
|
Sorry I'm very busy lately. But now I fixed the merge conflict. So it should hopefully be ready to be merged :) |
test/Data/Swagger/SchemaSpec.hs
Outdated
| @@ -105,6 +108,7 @@ spec = do | |||
| context "MyRoseTree' (inlineNonRecursiveSchemas)" $ checkInlinedRecSchema (Proxy :: Proxy MyRoseTree') myRoseTreeSchemaJSON' | |||
| describe "Bounded Enum key mapping" $ do | |||
| context "ButtonImages" $ checkToSchema (Proxy :: Proxy ButtonImages) buttonImagesSchemaJSON | |||
| context "TimeOfDay" $ checkToSchema (Proxy :: Proxy Data.Time.LocalTime.TimeOfDay ) timeOfDaySchemaJSON | |||
There was a problem hiding this comment.
| context "TimeOfDay" $ checkToSchema (Proxy :: Proxy Data.Time.LocalTime.TimeOfDay ) timeOfDaySchemaJSON | |
| context "TimeOfDay" $ checkToSchema (Proxy :: Proxy Data.Time.LocalTime.TimeOfDay) timeOfDaySchemaJSON |
| -- >>> toParamSchema (Proxy :: Proxy TimeOfDay) ^. format | ||
| -- Just "hh:MM:ss" | ||
| instance ToParamSchema TimeOfDay where | ||
| toParamSchema _ = timeParamSchema "hh:MM:ss" |
There was a problem hiding this comment.
Why are hh, ss small, but MM is capitalized? Could you explain this in the haddocks?
There was a problem hiding this comment.
Actually I am not sure if it makes a difference if MM is capitalized or not. I just took the schema that was used for LocalTime ("yyyy-mm-ddThh:MM:ss") and removed the parts I didn't need.
So basically I left the M capitalized for being consistent, but I don't know if there is another reason.
fix #87