-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GHC 9.2 #231
Support GHC 9.2 #231
Conversation
Does the test suite pass for you with this patch applied? Because it didn't for me (as you can see in the bottom of that comment you refer to). |
✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨ I haven't tried; I just needed the bounds updated to get Servant building on GHC 9.2 |
@ysangkok there is long-standing GHC bug that should be fixed in 9.2, i.e. failing doctests such as: instance ToSchema Person Surely, we can add that support. I was hoping that bug will gone. Let me further look into that. |
Other (unrelated to this PR) thing I want to pay attention is too relaxed |
@swamp-agr The PR I made yesterday doesn't fix the aeson issue? |
@ysangkok for some reason I missed it. |
@brandon-leapyear could you please rebase/merge over the Merged #230? |
✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨ Done |
Thanks @brandon-leapyear! I just realised that we have to ensure on CI that 9.2 is good. I will check it separately via #232. |
@swamp-agr I have submitted a PR to fix that. |
✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨
Resolves #227, uses the fix in the comments