-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3341 - fix parsing loose version format #3379
Conversation
Your fix looks quite good! I didn't find any suggestions for improvements. Maybe it might be an idea to create an additional integration test for that scenario the release branch is not in strict format: [TestCase("release/1.2.0", "1.2.0-beta.1+1", SemanticVersionFormat.Loose)]
[TestCase("release/1.2.0", "1.2.0-beta.1+1", SemanticVersionFormat.Strict)]
[TestCase("release/1.2", "1.2.0-beta.1+1", SemanticVersionFormat.Loose)]
[TestCase("release/1", "1.0.0-beta.1+1", SemanticVersionFormat.Loose)]
public void ShouldDetectVersionInReleaseBranch(
string branchName, string expectedVersion, SemanticVersionFormat semanticVersionFormat)
{
var configuration = GitFlowConfigurationBuilder.New
.WithSemanticVersionFormat(semanticVersionFormat)
.Build();
using var fixture = new EmptyRepositoryFixture(branchName);
fixture.MakeACommit();
fixture.AssertFullSemver(expectedVersion, configuration);
} |
sure I will include this one as well, thanks |
Thank you @arturcic for your contribution! |
Fixes #3341