-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] chore: rely on Page.frameStartedNavigating
CDP event
#3104
Draft
sadym-chromium
wants to merge
3
commits into
main
Choose a base branch
from
sdaym/navigation-tracker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
browser-automation-bot
added a commit
to browser-automation-bot/chromium-bidi
that referenced
this pull request
Feb 10, 2025
sadym-chromium
pushed a commit
that referenced
this pull request
Feb 11, 2025
Update the expectations for PR #3104. Automatically generated by https://github.com/GoogleChromeLabs/chromium-bidi/blob/main/.github/workflows/wpt.yml
Update the expectations for PR #3104. Automatically generated by https://github.com/GoogleChromeLabs/chromium-bidi/blob/main/.github/workflows/wpt.yml
c527aab
to
35add8c
Compare
browser-automation-bot
added a commit
to browser-automation-bot/chromium-bidi
that referenced
this pull request
Feb 11, 2025
Update the expectations for PR #3104. Automatically generated by https://github.com/GoogleChromeLabs/chromium-bidi/blob/main/.github/workflows/wpt.yml
browser-automation-bot
added a commit
to browser-automation-bot/chromium-bidi
that referenced
this pull request
Feb 11, 2025
sadym-chromium
added a commit
that referenced
this pull request
Feb 11, 2025
Extend test coverage for navigation. Extracted from #3104.
This PR is blocked for now by edge case with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.