Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version:20191112.0 #866

Merged
merged 2 commits into from
Nov 12, 2019
Merged

Version:20191112.0 #866

merged 2 commits into from
Nov 12, 2019

Conversation

hopkiw
Copy link
Contributor

@hopkiw hopkiw commented Nov 12, 2019

No description provided.

@codecov
Copy link

codecov bot commented Nov 12, 2019

Codecov Report

Merging #866 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #866   +/-   ##
============================================
  Coverage        97.32%   97.32%           
============================================
  Files               58       58           
  Lines             4784     4784           
  Branches           245      245           
============================================
  Hits              4656     4656           
  Misses             109      109           
  Partials            19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac3db2a...df33bd7. Read the comment docs.

Copy link

@zmarano zmarano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hopkiw
Copy link
Contributor Author

hopkiw commented Nov 12, 2019

I think we can eliminate the historical version lock between these packages. For right now, explicitly declaring the current package dependency (and bumping packaging revisions, since no contents are changing).

@google-oss-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hopkiw, zmarano
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@zmarano zmarano merged commit 586528f into GoogleCloudPlatform:development Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants