Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Disable overcommit accounting on E2 VMs (#865)" #871

Merged
merged 1 commit into from
Nov 15, 2019

Conversation

zmarano
Copy link

@zmarano zmarano commented Nov 15, 2019

This reverts commit 880daf9.

@codecov
Copy link

codecov bot commented Nov 15, 2019

Codecov Report

Merging #871 into development will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #871      +/-   ##
===============================================
+ Coverage        97.32%   97.36%   +0.04%     
===============================================
  Files               58       58              
  Lines             4784     4782       -2     
  Branches           245      244       -1     
===============================================
  Hits              4656     4656              
+ Misses             109      108       -1     
+ Partials            19       18       -1
Impacted Files Coverage Δ
...engine/instance_setup/tests/instance_setup_test.py 100% <100%> (ø) ⬆️
...le_compute_engine/instance_setup/instance_setup.py 94.55% <100%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d69a33...b7c11ad. Read the comment docs.

Copy link
Contributor

@wrigri wrigri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@google-oss-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adjackura, wrigri, zmarano
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zmarano zmarano merged commit f79b198 into GoogleCloudPlatform:development Nov 15, 2019
zmarano pushed a commit that referenced this pull request Nov 15, 2019
@zmarano zmarano deleted the rollback branch December 10, 2019 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants