Disable overcommit accounting on E2 VMs (again) #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #874 +/- ##
===============================================
+ Coverage 97.36% 97.37% +<.01%
===============================================
Files 58 58
Lines 4783 4801 +18
Branches 244 245 +1
===============================================
+ Hits 4657 4675 +18
Misses 108 108
Partials 18 18
Continue to review full report at Codecov.
|
illfelder
reviewed
Nov 19, 2019
packages/python-google-compute-engine/google_compute_engine/instance_setup/instance_setup.py
Outdated
Show resolved
Hide resolved
packages/python-google-compute-engine/google_compute_engine/instance_setup/instance_setup.py
Outdated
Show resolved
Hide resolved
packages/python-google-compute-engine/google_compute_engine/instance_setup/instance_setup.py
Outdated
Show resolved
Hide resolved
packages/python-google-compute-engine/google_compute_engine/instance_setup/instance_setup.py
Outdated
Show resolved
Hide resolved
...thon-google-compute-engine/google_compute_engine/instance_setup/tests/instance_setup_test.py
Outdated
Show resolved
Hide resolved
...thon-google-compute-engine/google_compute_engine/instance_setup/tests/instance_setup_test.py
Outdated
Show resolved
Hide resolved
hopkiw
force-pushed
the
e2_again
branch
2 times, most recently
from
cbd3463 to
8668367
Compare
illfelder
reviewed
Nov 20, 2019
packages/python-google-compute-engine/google_compute_engine/instance_setup/instance_setup.py
Outdated
Show resolved
Hide resolved
illfelder
reviewed
Nov 20, 2019
packages/python-google-compute-engine/google_compute_engine/instance_setup/instance_setup.py
Outdated
Show resolved
Hide resolved
illfelder
approved these changes
Nov 20, 2019
...thon-google-compute-engine/google_compute_engine/instance_setup/tests/instance_setup_test.py
Outdated
Show resolved
Hide resolved
...thon-google-compute-engine/google_compute_engine/instance_setup/tests/instance_setup_test.py
Outdated
Show resolved
Hide resolved
illfelder
reviewed
Nov 20, 2019
...thon-google-compute-engine/google_compute_engine/instance_setup/tests/instance_setup_test.py
Outdated
Show resolved
Hide resolved
illfelder
reviewed
Nov 20, 2019
...thon-google-compute-engine/google_compute_engine/instance_setup/tests/instance_setup_test.py
Outdated
Show resolved
Hide resolved
illfelder
approved these changes
Nov 20, 2019
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hopkiw, illfelder The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.