Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll forward a fix for #862. #876

Merged
merged 2 commits into from
Dec 5, 2019

Conversation

illfelder
Copy link
Contributor

Support retry limits in metadata retrieval.

@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #876 into development will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #876   +/-   ##
============================================
  Coverage        97.37%   97.37%           
============================================
  Files               58       58           
  Lines             4801     4801           
  Branches           245      246    +1     
============================================
  Hits              4675     4675           
  Misses             108      108           
  Partials            18       18
Impacted Files Coverage Δ
...ompute_engine/metadata_scripts/script_retriever.py 100% <ø> (ø) ⬆️
...ne/metadata_scripts/tests/script_retriever_test.py 100% <ø> (ø) ⬆️
...ogle_compute_engine/tests/metadata_watcher_test.py 100% <100%> (ø) ⬆️
...e-engine/google_compute_engine/metadata_watcher.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae38eea...5bb46c2. Read the comment docs.

Support retry limits in metadata retrieval without changing guest
behaviors.
@illfelder illfelder changed the title Revert #875 and maintain original behaviors. Roll forward a fix for #862. Nov 21, 2019
Copy link
Contributor

@wrigri wrigri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@google-oss-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hopkiw, illfelder, wrigri
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@illfelder illfelder merged commit ee8099d into GoogleCloudPlatform:development Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants