Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disk expand for EL7 race conditions. #888

Merged
merged 2 commits into from
Apr 20, 2020

Conversation

zmarano
Copy link

@zmarano zmarano commented Apr 17, 2020

Proposed fix for disk expansion race condition.

@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #888 into development will increase coverage by 1.29%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #888      +/-   ##
===============================================
+ Coverage        96.07%   97.37%   +1.29%     
===============================================
  Files               57       58       +1     
  Lines             4769     4801      +32     
  Branches           244      246       +2     
===============================================
+ Hits              4582     4675      +93     
+ Misses             162      108      -54     
+ Partials            25       18       -7     
Impacted Files Coverage Δ
...-engine/google_compute_engine/boto/compute_auth.py 100.00% <0.00%> (ø)
...le_compute_engine/instance_setup/instance_setup.py 94.77% <0.00%> (+0.65%) ⬆️
...compute_engine/metadata_scripts/script_executor.py 96.87% <0.00%> (+3.12%) ⬆️
...gle-compute-engine/google_compute_engine/compat.py 75.36% <0.00%> (+15.94%) ⬆️
...ompute-engine/google_compute_engine/test_compat.py 88.88% <0.00%> (+22.22%) ⬆️
...gle_compute_engine/boto/tests/compute_auth_test.py 100.00% <0.00%> (+77.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dad8239...e12e335. Read the comment docs.

@hopkiw
Copy link
Contributor

hopkiw commented Apr 20, 2020

/lgtm

@hopkiw hopkiw self-requested a review April 20, 2020 18:01
@@ -28,4 +28,5 @@ dracut_install grep
dracut_install resize2fs
dracut_install e2fsck
dracut_install udevadm
dracut_install systemctl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did it not work without this?? initrd should have its own systemctl, i'm unsure what the behavior is if we import the system systemctl binary

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't try... this is technically what you should do for any of these things (its like declaring your package dependencies). In any case, it would not hurt as it would just re-copy the same thing if its done elsewhere.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears from other modules that use it- that this is not required... I'll remove it.

@zmarano zmarano merged commit 84bb53e into GoogleCloudPlatform:development Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants