-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix disk expand for EL7 race conditions. #888
Fix disk expand for EL7 race conditions. #888
Conversation
Codecov Report
@@ Coverage Diff @@
## development #888 +/- ##
===============================================
+ Coverage 96.07% 97.37% +1.29%
===============================================
Files 57 58 +1
Lines 4769 4801 +32
Branches 244 246 +2
===============================================
+ Hits 4582 4675 +93
+ Misses 162 108 -54
+ Partials 25 18 -7
Continue to review full report at Codecov.
|
9fa3bc3
to
cb16656
Compare
/lgtm |
@@ -28,4 +28,5 @@ dracut_install grep | |||
dracut_install resize2fs | |||
dracut_install e2fsck | |||
dracut_install udevadm | |||
dracut_install systemctl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did it not work without this?? initrd should have its own systemctl, i'm unsure what the behavior is if we import the system systemctl binary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't try... this is technically what you should do for any of these things (its like declaring your package dependencies). In any case, it would not hurt as it would just re-copy the same thing if its done elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears from other modules that use it- that this is not required... I'll remove it.
Proposed fix for disk expansion race condition.