Interim fix fo EL7 GPT header move race condition with systemd-fsck. #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #891 +/- ##
============================================
Coverage 97.37% 97.37%
============================================
Files 58 58
Lines 4801 4801
Branches 246 246
============================================
Hits 4675 4675
Misses 108 108
Partials 18 18 Continue to review full report at Codecov.
|
illfelder
reviewed
Apr 28, 2020
illfelder
approved these changes
Apr 28, 2020
zmarano
changed the title
hopkiw
reviewed
Apr 28, 2020
| @@ -1,3 +1,9 @@ | |||
| gce-disk-expand (1:20200428.00-g1) stable; urgency=medium | |||
There was a problem hiding this comment.
we don't edit these files anymore - they will be overwritten during build anyway
| @@ -14,7 +14,7 @@ | |||
| # limitations under the License. | |||
|
|
|||
| NAME="gce-disk-expand" | |||
| VERSION="20190708.00" | |||
| VERSION="20200428.00" | |||
There was a problem hiding this comment.
the build system provides versions. this file and others like it are unused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This race manifests depending on how quickly the system boots and is more prevalent on some faster systems. When running the GPT move header operation multiple systemd-fsck tasks are spawned because of device enumeration. These can overrun each other and cause failures. Adding a sleep before and after this operation resolves the race. But we should find another solution that doesn't rely on sleep if possible.
Also add better console logging messages to the steps being run.