Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuring separator in AppendingTransformer #1169

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Jan 18, 2025

@Goooler Goooler changed the title Support configuring separator in AppendingTransformer Support configuring separator in AppendingTransformer Jan 18, 2025
@Goooler Goooler force-pushed the g/20250118/optional-line-seprator-in-appending branch 2 times, most recently from 1c8d32f to c9afb41 Compare January 18, 2025 10:49
@Goooler Goooler force-pushed the g/20250118/optional-line-seprator-in-appending branch from c9afb41 to 5e9f24f Compare January 18, 2025 11:12
@Goooler Goooler requested a review from Copilot January 18, 2025 11:13

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • api/shadow.api: Language not supported
  • src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/AppendingTransformerTest.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowSpec.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/AppendingTransformer.kt: Language not supported
@Goooler Goooler merged commit 8300f91 into main Jan 18, 2025
7 checks passed
@Goooler Goooler deleted the g/20250118/optional-line-seprator-in-appending branch January 18, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit current transformers for cachebility Support for merging YAML files
1 participant