-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dt 5248 Display subway entrance information #5235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the PR wih HSL ui theme. The only difference I could see is an additional itinerary detail row 'Sisäänkäynti M / Uloskäynti M', which is quite useless information.
Is this a data issue? Where can I find more accurate entrance labels?
Also, there seems to be two PRs open, one is a draft and apparenly has wrong title. Please clean up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some review notes:
- Steissi - Itis metro journey renders two entrances A and D on map in Itis. Is this intentional?
- New figma design shows map icons vertically - not horizontally - aligned. There is no wheelchair icon on map, it is only shown in a map popup which is missing now. Are these differences intentional?
- Figma designs shows a narrow gap between entrance icons. Currently there is no separating space.
- Icons always render quite large. Other map icons scale by zoom level. Is this by design?
This reverts commit 7a76e07.
Proposed Changes
Pull Request Check List
Review