Add save button to twix #1665
Merged
Add save button to twix #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleflb
requested changes
Mar 5, 2025
|
Oh and you need to increase the minor version in twix 😉 You can find it in the twix Cargo.toml :) |
|
Please enable merge when ready to merge the PR. |
|
@oleflb all comments have to be resolved to have this PR merged |
|
resolved now. still waiting for merge when ready @Franziska-Sophie |
ThagonDuarte
pushed a commit
to ThagonDuarte/hulk
that referenced
this pull request
Mar 10, 2025
* add save button to twix for saving camera image as png/jpeg * fix imports * update twix version to 0.9.3 * moved implementation of saving a jpeg image to an impl block of JpegImage * wip * removed some comments * format 'jpeg.rs'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
Adds a "Save" button to twix in the image pannel that saves the camera image as PNG/JPEG file. The images are then stored in /tmp/twix.
How to Test
Open the image pannel in twix and click on the save button (with and without the JPEG box checked). Check in /tmp/twix if the image was saved.