Feras aldmeashki-w2-javascript #12
Conversation
| } | ||
|
|
||
| function main() { | ||
| // TODO substitute your own name for "HackYourFuture" | ||
| const myName = 'HackYourFuture'; | ||
| const myName = 'Feras Al-Demashki'; | ||
|
|
||
| console.log(giveCompliment(myName)); | ||
| console.log(giveCompliment(myName)); |
There was a problem hiding this comment.
Nice job looks good! 😎 Your variable called randomCompliments could have been named better because it returns a random number. So for instance randomNumber or randomIndex. This will make the variable more meaningful and easier to understand for other people reading the codebase :)
There was a problem hiding this comment.
Thanks, I'll edit that and keep it in mind for future
| const partnerNames = selectRandomly(y); | ||
| const locations = selectRandomly(s); | ||
| const jobTitles = selectRandomly(z); | ||
| return `You will be a ${jobTitles} in ${locations}, married to ${partnerNames} with ${numKids} kids.`; |
There was a problem hiding this comment.
Good job, the choice to create multiple variables for each part of your sentence makes it easy to read :)
| function addToShoppingCart(/* parameters go here */) { | ||
| // TODO complete this function | ||
| function addToShoppingCart(item) { | ||
| if (item === undefined) { |
There was a problem hiding this comment.
In this case what you could have done is use !item that means there is no item specified. When using undefined you state that a variable has been declared but has not been assigned a value. So let's say someone adds the following:
let x;
addToShoppingCart(x);
This if statement wouldn't work. Then (if I am correct) the shoppingCart.push would add a empty item to the array.
| if (shoppingCart.length > 3) { | ||
| shoppingCart.shift(); | ||
| } | ||
| return `You bought ${shoppingCart.join(', ')}!`; |
| function addToShoppingCart(/* TODO parameter(s) go here */) { | ||
| // TODO complete this function | ||
| function addToShoppingCart(shoppingCart, item) { | ||
| const newShoppingCart = shoppingCart.concat(item); |
There was a problem hiding this comment.
The concat method is used to merge multiple array's. In this case the item is a single value and not of type array so it would be best to either push or unshift method.
There was a problem hiding this comment.
i replaced it with .push
| for (let item in cart) { | ||
| total += cart[item]; | ||
| } | ||
| return `Total: €${total}`; |
There was a problem hiding this comment.
Good job, and it seems to work well. This could have also been done with the reduce function like so (the reduce function is often used to sum values):
array.reduce((accumulator, currentValue) => {
// logic
}, initialValue);
const numbers = [1, 2, 3, 4, 5];
const sum = numbers.reduce((total, value) => total + value, 0);
console.log(sum);
There was a problem hiding this comment.
i will check the reduce function that's for sure
| name: employee.name, | ||
| occupation: employee.occupation, | ||
| email: employee.email, | ||
| }; |
There was a problem hiding this comment.
Well done. Something else you could have done is deconstruct the object like so:
const { name, occupation, email } = employee
No description provided.