Make Equip Swap work on Pause Menu with 'Any Cursor' Enhancement

[inspectredc]

null

Build Artifacts

• soh.otr.zip
• soh-linux-compatibility.zip
• soh-wiiu.zip
• soh-switch.zip
• soh-linux-performance.zip
• soh-windows.zip
• soh-mac.zip

[briaguya-ai]

i know this is a new feature but really it feels like a bugfix - mind making a PR pointing to macready for it?

[inspectredc]

Cool! I was gonna ask if i could point this to macready cause I want it sooner haha

[inspectredc]

Now pointing towards macready 👍🏼

[briaguya-ai]

it'd be great to have a few people pull down test builds and try out a few swaps, but that's definitely not required for us to

[inspectredc]

Oh yea, I have a video showcasing here too if that helps!

EquipSwap.mp4

[Malkierian]

WTF, how'd you figure out it was such a miniscule change?

[inspectredc]

I think I always knew the issue was basically that the evaluation of 'can we move to any slot' was the issue when moving from the Z/R buttons. To quote my own explanation in the race-chat

"basically what happens is that it has always correctly gone from the Z/R buttons to the correct item, but the up input then causes it to go 1 up from there. the way equip swap works is that itll only update the current hovered item as long as the movement of the cursor was evaluated as a success". "since left/right inputs are done before up/down inputs the last state of the movement ends up being a fail, except with the enhancement where it allows it to succesfully move up"

then also the reason why this is frame perfect is that the hovered item gets set to 0 when on the Z/R buttons, but only after the evaluation occurs the very first time. there's a special case to basically ignore up/down inputs when the hovered item is 0 (note that I believe we dont update the hovered item to 0 when we move over empty slots, potentially allowing for a special new kinda equip swap I might investigate..) (looks like it does update when not starting from the Z/R buttons)

[Malkierian]

Confirmed working on my end.

[Caladius]

Not that I'm looking to add work but would it be beneficial to remove the Cursor on any Slot option and default it to Only in Rando? Since the player would no longer need to toggle it for Equip Swap, I'm unsure if there's any reason to set it to Never anymore

[Malkierian]

Could it still be useful in vanilla speedruns? If so, we wouldn't want to remove the option completely. Changing the default, if it's not Only In Rando, would probably be good, though.

[Malkierian]

Unless you meant to say "remove the Cursor On Any Slot Never option".

[Caladius]

Could it still be useful in vanilla speedruns? If so, we wouldn't want to remove the option completely. Changing the default, if it's not Only In Rando, would probably be good, though.

Maybe? Not really sure on that. More of a "Can we use this to clean up the UI options somehow in a future PR"

[inspectredc]

I personally can still see the reason why someone might want to have the only in rando option exist, for example, if they want to do speedruns on a vanilla file, but also still play rando. Maybe once we have better presets it can be removed

[Malkierian]

If we think there's no reason to have it off in rando, though, we could just have it always on in rando in code, and have it be a toggle for applying to vanilla?

[Malkierian]

Still probably something for a later PR, though.

[inspectredc]

I think with rando v3 we're generally moving away from IS_RANDO without a cvar anyway (or smth to that effect)

[Caladius]

100%, sorry if that wasnt apparent in my intentions. Not for this PR