Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add X509CA implementation #145

Merged
merged 8 commits into from
May 2, 2023
Merged

Add X509CA implementation #145

merged 8 commits into from
May 2, 2023

Conversation

maxlambrecht
Copy link
Contributor

Pull request check list

  • Proper tests/regressions included?
  • Documentation updated?

Affected functionality

Defines an interface for issuing X.509 Certificates and a disk-based implementation.
Add the providers configuration for the Server.
Defines a Catalog for managing Providers.

Description of change
Add cryptoutil package for parsing and generating certificates and keys.

Which issue this pull requests fixes

Fixes GLCP-42539

@maxlambrecht
Add X509CA implementation
4ca8ff9 
Signed-off-by: Max Lambrecht <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 24, 2023
View reviewed changes
conf/server/dummy_root_ca.key
@@ -0,0 +1,51 @@
-----BEGIN RSA PRIVATE KEY-----

Check failure

Code scanning / Trivy

Asymmetric Private Key

Artifact: conf/server/dummy_root_ca.key Type: Secret Asymmetric Private Key Severity: HIGH Match: ----BEGIN RSA PRIVATE KEY-----**************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************-----END RSA PRIVATE
@maxlambrecht
Fix lint errors
92a8338 
Signed-off-by: Max Lambrecht <[email protected]>
@maxlambrecht
Fix lint errors
9985eb2 
Signed-off-by: Max Lambrecht <[email protected]>
@maxlambrecht
Fix lint errors
e40b524 
Signed-off-by: Max Lambrecht <[email protected]>
jufantozzi
jufantozzi reviewed Apr 27, 2023
View reviewed changes
Copy link
Contributor

@jufantozzi jufantozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a first pass through and its looking pretty good! Most of my comments are either questions or nitpicks.

mgbcaio
mgbcaio reviewed Apr 27, 2023
View reviewed changes
Copy link
Collaborator

@mgbcaio mgbcaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good for me, left only one super picky comment. Just waiting on others to review it so I can approve. Great job, as always ;)

Victorblsilveira
Victorblsilveira reviewed Apr 27, 2023
View reviewed changes
Copy link
Collaborator

@Victorblsilveira Victorblsilveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of work here. Overall all look great. Just some minors

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
1.5% 1.5% Duplication

mgbcaio
mgbcaio approved these changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@mgbcaio mgbcaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦾

jufantozzi
jufantozzi approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@jufantozzi jufantozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@maxlambrecht maxlambrecht merged commit a02b1c4 into HewlettPackard:main May 2, 2023
@maxlambrecht maxlambrecht deleted the feature/x509ca branch May 2, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Victorblsilveira Victorblsilveira Victorblsilveira left review comments

@jufantozzi jufantozzi jufantozzi approved these changes

@mgbcaio mgbcaio mgbcaio approved these changes

@wibarre wibarre Awaiting requested review from wibarre wibarre is a code owner

@mchurichi mchurichi Awaiting requested review from mchurichi mchurichi is a code owner

Assignees

@maxlambrecht maxlambrecht

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxlambrecht @Victorblsilveira @jufantozzi @mgbcaio