Improve layout of the release artifact. #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxlambrecht
requested review from
wibarre,
mchurichi,
jufantozzi,
mgbcaio and
Victorblsilveira
as code owners
Signed-off-by: Max Lambrecht <[email protected]>
maxlambrecht
force-pushed
the
fix-build-artifact
branch
from
e91cf24 to
50ac90d
Compare
Signed-off-by: Max Lambrecht <[email protected]>
| if [[ "$GITHUB_REF" =~ ^refs/tags/v[0-9.]+$ ]]; then | ||
| echo "${GITHUB_REF##refs/tags/v}" | ||
| else | ||
| echo "" |
There was a problem hiding this comment.
can we have empty tags ?
There was a problem hiding this comment.
I added the error handling.
Signed-off-by: Max Lambrecht <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Victorblsilveira
approved these changes
Jun 7, 2023
maxlambrecht
pushed a commit
that referenced
this pull request
Jun 7, 2023
Signed-off-by: Max Lambrecht <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request check list
Affected functionality
Description of change
Change the
build_artifactsscript to enhance the structure of the generated tarball. The improved layout is designed to make the contents more organized and intuitive for users.The new tarball structure is:
galadriel-{version}: This is the root directory within the tarball. The version of the Galadriel build is reflected in the directory name to aid version identification.bin/: This directory contains all the binary files resulting from the build process.conf/: This directory holds all configuration files.LICENSE: This is the license file for Galadriel.This PR also refines
build_artifacts.shby introducing separate functions for tarball creation and artifact building, improving variable names, and optimizing variable assignments.Which issue this pull requests fixes