Reduce dependencies, especially for Classes #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, Classes was using Utf8.v, which depends on a large part of the library. We break out a small section of Utf8.v into a new file to avoid this. Now Classes doesn't depend on WildCat.v, for example.
Alizter
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the Classes library was depending on WildCat, Cubical, Modalities, Homotopy.Suspension, etc, all because it uses some unicode symbols defined in Utf8.v. I separated that small subset into a new file Utf8Minimal.v, which greatly reduces the dependencies and speeds up a parallel build by about 2%. I also reduced a few other dependencies. I noticed these because so much of the library was getting rebuilt when WildCat/Induced.v was changed.
The commits are independent, except that the fourth one depends on the third one.