python: Framework style. Bug fixes. #12968
Conversation
|
|
||
| # The HOMEBREW_PREFIX location of site-packages. | ||
| def site_packages | ||
| HOMEBREW_PREFIX+"lib/python2.7/site-packages" |
There was a problem hiding this comment.
Would those 2.7 be easier to maintain as a variable?
There was a problem hiding this comment.
One could use #{version.to_f}:
[irb(main)]$ "2.7.3".to_f
====> 2.7
There was a problem hiding this comment.
For Python 3.x I will use this suggestions.
However, there will be no Python 2.8. It's a dead end.
|
Haven't looked at the python3 request yet, but feel free to apply my review comments there as well, if they are relevant. |
|
@jacknagel thanks very much for you helpful comments. I'll push a sqaushed new version with almost all of your suggestions except for the "? ?" stuff until you sudo me to do. Most of them apply to python3, too. Will fix it. |
|
done. |
|
Updated this pull request and fixed minor things. |
|
ping. |
|
@jacknagel @adamv please review when you have time. |
|
@jacknagel @adamv This PR turns out to fix compile errors on ML also. Please review. |
|
I still don't want to make Framework the default, but I've also abdicated maintaining the Python formulae, so if another maintainer wants to pull, be my guest. |
|
A small typo fix and added the small suggestion @paxswill made for python3. @adamv today there are many more reasons why one wants a framework build than not. Apple and python.org do a framework build on the Mac. Some GUI libs only work with the framework version. There may have been issues with the framework build in the past. That's past now :-) |
Why? |
|
/unsubscribe |
|
I'll "maintain" this formula by looking at the related issues and doing pull-requests. I swear. Ok, perhaps @jacknagel or @mistydemeo want to pull the trigger? |
|
@MikeMcQuaid @Sharpie this would be a significant change, making Python a framework by default. Thoughts? |
|
@mistydemeo @jacknagel, I removed the "--no-framework" option. Look how clean the formula looks again. |
|
Coffee and pull request. My morning ritual. |
|
@samueljohn clean up the commit message a bit and I'll merge :) |
|
@MikeMcQuaid cleaned up commit message a bit (the duplicate mention of sqlite and Framework is not the default, its the only way we go now) |
|
👉 hint, there is a python3 formula waiting for some ❤️, too. |
- Framework style build in order to support wxmac and other GUIs (Note: PySide (and pyqt?) seem to work even with non-framework builds). - Fixed automatic installation of `*.app`s into `/Applications`. - The caveats tell us now about `brew link apps`. - Cleanup of the caveats. - Resolve the issue of duplicate `2to3` can make the symlink phase to break because both python and python3 provide it. (Closes Homebrew#12581) - Enable warnings, because python's configure needs it. (Closes Homebrew#12194) - Add suppression of recommended warnings from the python docs. - Add work-a-round for python bug: http://bugs.python.org/issue11445 - Add explicit test if sqlite3 built successful. - Check against possible issue like Homebrew#12667. - Add needed "depends_on :x11" because tk.h includes x11. - Install the Demo into HOMEBREW_PREFIX/share/python2.7/Extras - Ensure sqlite from homebrew is used and not the one from OS X. - Removed unnecessary flags from configure - Added --without-gcc to the configure flags (all clang now) - Ensure that "man python2.7" works by setting --datadir and --datarootdir to share.
|
Updated with last-minute review from @jacknagel. To be precise: added |
|
Great. I'll merge this tomorrow unless there's any final complaints. |
|
Python3 goes in |
|
I don't think so. Python 3 is a major jump with a lot of changes to the language, breaking backwards compatibility. Code written for one won't run without modification for the other, and active development is only happening in Python 3. |
So yeah: |
|
As a Python user, I'd say this is not a candidate for versions. Both Python3 does not provide an executable named "python" and even if it When I chatted with one of the core devs, he told me it's better to As has been said before, python 2.x does not get new features. So in When 3.3 will be released, 3.2 could be a candidate for versions since I hope I am able to convince you @mxcl. |
|
We keep one in |
|
@mxcl because running Python 2 and 3 side-by-side is way more common than running Grails 1.3.4 and Grails 2.0 side-by-side, for instance. |
|
That said, I don't care, do whatever. |
|
I do care :-( |
|
It's akin to the early days of the OS 9 to OS X jump. Both are needed for different tasks, and while you can see that one is descended from the other, they're also different things that are needed at the same time. Here's why both are needed at the same time. Ideally, Python 3 only would be great, but Python 2 is needed for too many things. |
|
I don't get the complaints. Putting it in the versions tap doesn't change anything. Just where the formula lives. Is it a prestige thing or something? Nobody wants their favorite formula moved to a tap? |
|
If the user concludes to type But I'll stop arguing, you decide. |
|
One issue I think of is how will upgrades work? If Python 3 is moved to versions, and then the next release comes out, how will people who currently have Python 3 and do not have versions tapped be upgraded? Also, this might be an area for improvement, but As an aside, I think this Python 3 discussion might be better located in #12969. |
|
I think there's an argument that |
|
@MikeMcQuaid please note that there are several issues with Apple's python 2.7 e.g. you need |
|
I was thinking about making install do a search if it finds nothing. But let's think about how people use brew for a second. Who tries to install things by typing hopeful-strings in to install? Nobody I hope. The upgrade issue is true. |
|
I'm maybe a minority but that's what I always tend to do. Hear about new thing, type string into I'm just testing this and about to merge this. Regardless of the future of |
|
Merged as a97c817. Thanks @samueljohn for all the hard work. |
|
Thanks for pulling. ❤️ I often do |
(Note: PySide (and pyqt?) seem to work even with non-framework builds).
*.apps into/Applications.brew link apps.2to3can make the symlink phaseto break because both python and python3 provide it. (Closes Linking 2to3 fails when installing both Python and Python3 #12581)