Change operator to allow major semantic changes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HughbertD Could you merge this? It'd let us close unsplash/unsplash-php#60 💖 |
|
@HughbertD Are you planning on releasing a new version of this repo with this fix? That would allow us to fix unsplash/unsplash-php#76 (comment). Unsplash v4 is not usuable at the moment without adding the Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears the change to allow for earlier versions of the league/oauth2-client library. The composer.lock and composer.json seem to be out of sync, so I am assuming this was a quick fix without testing.
The operator prefixing the version (^) uses semantic versioning to limit usage where there may be breaking changes. Due to this, I suggest changing the caret to a good ol' ">=".
This causes problems specifically because if you're using the League client with one API, you probably use it with multiple APIs, and it creates conflicts using the older version when you're already using the new version.
Anyway, let me know if you have any questions. It's super simple, and I didn't create a new lock file (in the PR). I figured I would leave that up to you.
unsplash/unsplash-php#60 (comment)