Warn when generating overly large repr #3848
Conversation
| data._sampled_from_all_strategies_elements_message = ( | ||
| "sample_from was given a collection of strategies: " | ||
| f"{preamble}{strat_reprs}. Was one_of intended?" | ||
| "{!r}. Was one_of intended?", self.elements |
There was a problem hiding this comment.
The warning triggered on this code - on win only, for some reason - so I delayed the repr until we actually add the note.
Since it caused a test failure, I propose that this does not violate the one-purpose-PR rule ;-)
There was a problem hiding this comment.
Note - max 3 is removed, since I think it was only added as a workaround for this specific problem in the first place
There was a problem hiding this comment.
(not really outdated, I just rebased for the RELEASE.rst conflict)
jobh
force-pushed
the
warn-construct-overly-long-repr
branch
from
d8cdbd6 to
0128ab1
Compare
There was a problem hiding this comment.
Thanks @jobh! I'm not sure whether to hope that we'll never need this, or that it'll save our bacon someday - but I'm very glad to have it.
I just don't understand why the coverage job is claiming it's missed a line, when I can see that test_define_function_signature_validates_function_name does execute it!
I guess the new test should be moved to tests/cover/, will do. |
|
That's just it though, the coverage problem is for previously-existing code, and the test is already in |
No, it's line 485 and that's I'll move the test quickly |
|
🤦 I must have had the wrong branch checked out, oops! |
For consideration, and submitted for the test runs.
A warning like this would have saved some development time lately, on #3820 and #3837.