Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin unfccc-di-api to latest release and reactivate tests #647

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Mar 15, 2022

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Name of contributors Added to AUTHORS.rst
  • Description in RELEASE_NOTES.md Added

Description of PR

This PR reverts #646 after @mikapfl fixed primap-community/unfccc_di_api#37.

@danielhuppmann danielhuppmann self-assigned this Mar 15, 2022
@danielhuppmann danielhuppmann added the dependencies Pull requests that update a dependency file label Mar 15, 2022
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #647 (5edf2fe) into main (e33fe00) will increase coverage by 0.6%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #647     +/-   ##
=======================================
+ Coverage   93.9%   94.5%   +0.6%     
=======================================
  Files         57      57             
  Lines       5662    5662             
=======================================
+ Hits        5317    5356     +39     
+ Misses       345     306     -39     
Impacted Files Coverage Δ
tests/test_unfccc.py 100.0% <100.0%> (+53.8%) ⬆️
pyam/unfccc.py 89.7% <0.0%> (+65.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e33fe00...5edf2fe. Read the comment docs.

@danielhuppmann danielhuppmann merged commit 4741cd8 into IAMconsortium:main Mar 15, 2022
coroa added a commit that referenced this pull request Mar 15, 2022
Co-authored-by: Daniel Huppmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests raise NodeIDAbsentError
1 participant