Multilingual db update #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lickem22
requested review from
sidravi1,
suzinyou and
amiraliemami
and removed request for
suzinyou
lickem22
changed the base branch from
feature-multilingual
to
feature-multilingual_support
lickem22
commented
Mar 19, 2024
lickem22
commented
Mar 19, 2024
lickem22
changed the base branch from
feature-multilingual_support
to
feature-multilingual
amiraliemami
requested changes
Mar 21, 2024
core_backend/migrations/versions/1ff08438751b_add_language_table.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks for this - really nice code and logic and tests!
Two points re. default language:
- Check out the comment on the "edit_language" router - I think that should be fixed to avoid causing a situation where there is no default language.
- Maybe we also add some logic onto the "create_language" endpoint to ensure there is always a default language?
…le.py Co-authored-by: Amir Emami <[email protected]>
Co-authored-by: Amir Emami <[email protected]>
Co-authored-by: Amir Emami <[email protected]>
About checking for a default language, we are already adding a default language in the migrations, so it shouldn't be an issue. So I suggest we keep it like this now and when we will build the language for frontend we will add the logic, by for example creating the language at launch if there is no language in the DB. |
amiraliemami
approved these changes
Mar 21, 2024
lickem22
added a commit
that referenced
this pull request
Apr 11, 2024
* Add language table and routes as well as tests * Add english as default language in migration * Fix typos * Update core_backend/migrations/versions/1ff08438751b_add_language_table.py Co-authored-by: Amir Emami <[email protected]> * Update core_backend/app/languages/models.py Co-authored-by: Amir Emami <[email protected]> * Update core_backend/app/languages/schemas.py Co-authored-by: Amir Emami <[email protected]> * Fix comments * Fix typos --------- Co-authored-by: Amir Emami <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @amiraliemami
Estimate: 1h
Ticket
Fixes: AAQ-382
Description, Motivation and Context
Goal
This PR is the first official PR as part of the multilingual support. The goal is to add the language table as well as the routes to be able to run CRUD operations.
Changes
Added a language submodule with the following files:
Added tests for languages
Also, since we are not planning on building a frontend for the languages yet, added english as the default language in the migration script.
How has this been tested?
This has been tested by manually testing the endpoints one by one and updating the tests.
Checklist
Fill with
xfor completed. Delete any lines that are not relevant