Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend error handling #495

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

WanjohiWanjohi
Copy link
Collaborator

@WanjohiWanjohi WanjohiWanjohi commented Mar 5, 2025

Reviewer:@lickem22
Estimate: 30 minutes


Ticket

Fixes: AAQ-897

Description

Goal

The goal of this PR is to improve error handling to show consistent errors using a SnackBar or Alert

Changes

The following changes have been made:

  • Use the CustomError utility in the integrations and urgency_rules components

How has this been tested?

Tested locally.

Checklist

Fill with x for completed.

  • My code follows the style guidelines of this project
  • I have reviewed my own code to ensure good quality
  • I have tested the functionality of my code to ensure it works as intended
  • I have resolved merge conflicts

@@ -1,13 +1,15 @@
import api from "@/utils/api";
import api, { CustomError, handleApiError } from "@/utils/api";
import axios from "axios";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused import

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

{snackbarMessage.message}
</Alert>
</Snackbar>
</Layout.FlexBox>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an tag that closed here but that was never opened. Probably happened during the merge with main

@lickem22
Copy link
Contributor

Thanks @WanjohiWanjohi, There i an issue with the urgency detection page whenever I click on it I get this :
Screenshot 2025-03-10 at 16 02 11
Can you check it out? I will continue the review after it's fixed

@WanjohiWanjohi WanjohiWanjohi requested a review from lickem22 March 11, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants