-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hot reloadable dev setup through make rundev #497
base: main
Are you sure you want to change the base?
Conversation
…ands to set up dev env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ziakhan04 ,
Made a few minor comments. But approved
@@ -139,3 +139,13 @@ setup-embeddings: guard-HUGGINGFACE_MODEL guard-HUGGINGFACE_EMBEDDINGS_API_KEY | |||
teardown-embeddings: | |||
@docker stop huggingface-embeddings | |||
@docker rm huggingface-embeddings | |||
|
|||
rundev: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should rename to run-docker-compose
and stop-docker-compose
COPY . . | ||
|
||
# Make startup script executable | ||
RUN chmod +x startup.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not useful anymore right?
@@ -4,8 +4,6 @@ | |||
from typing import AsyncIterator, Callable | |||
|
|||
import sentry_sdk | |||
import sklearn # noqa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removing this?
Reviewer: @lickem22
Estimate: 10 minutes
Ticket
Fixes: JIRA_TICKET_LINK
Description
Added the ability to run
make rundev
which will run the back end and front-end in hot reload mode, ie, changes made to the app will be reflected instantly.Goal
Make dev faster and easier.
Changes
Future Tasks (optional)
How has this been tested?
To-do before merge (optional)
Checklist
Fill with
x
for completed.(Delete any items below that are not relevant)