Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] Fix topic modelling issue where it fails sometimes #499

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lickem22
Copy link
Contributor

@lickem22 lickem22 commented Mar 12, 2025

Reviewer: @markbotterill
Estimate:20mins


Ticket

Fixes: AAQ-908

Description

Goal

The goal of this PR is to fix an issue in AAQ prod and testing where it fails sometimes but sometimes work

Changes

Here are the changes made to fix

  • Increase time outs
  • Create an sqlalchemy inside therefresh_insightsfunction instead of using the one from request. This is because that asession instance is supposed to close after the function finish executing.
  • Added TOKENIZERS_PARALLELISM environment variable to avoid warning about parallelism issue.

Future Tasks (optional)

  • The bokeh plot still seems to be buggy. Needs to be fixed

How has this been tested?

Can test by adding the dummy data using add_dummy_data.py. Then run discovey (better results when running two at the same time).

Checklist

Fill with x for completed.

  • My code follows the style guidelines of this project
  • I have reviewed my own code to ensure good quality
  • I have tested the functionality of my code to ensure it works as intended
  • I have resolved merge conflicts

Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant