Certificate Refactor: Rename thubmnail_image_path #9137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjansenDatabay
requested changes
Feb 28, 2025
There was a problem hiding this comment.
Hi @fhelfer ,
thanks for your PR.
can we ignore the changes in components/ILIAS/Course/tests/Certificate/ilCertificateCourseLearningProgressEvaluationTest.php ?
Best regards,
Michael
components/ILIAS/Certificate/classes/Setup/Migration/CertificateIRSSMigration.php
Outdated
Show resolved
Hide resolved
components/ILIAS/Certificate/classes/Setup/class.ilCertificateDatabaseUpdateSteps.php
Outdated
Show resolved
Hide resolved
...ents/ILIAS/Certificate/classes/Form/Repository/class.ilCertificateSettingsFormRepository.php
Outdated
Show resolved
Hide resolved
...ents/ILIAS/Certificate/classes/Form/Repository/class.ilCertificateSettingsFormRepository.php
Outdated
Show resolved
Hide resolved
...ILIAS/Certificate/classes/Template/Action/Import/class.ilCertificateTemplateImportAction.php
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the Certificate DB Column to fit the semantics more.
Since the Image is used for Card of Decks in the Achievement Tab of a User, the variable name tile_image is more fitting than thumbnail.