Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request json formatted downloads to be compatible with Dataverse #7178 #60

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Apr 7, 2021

This PR is the minimal update to stay compatible with instances of Dataverse running a release after the merge of #7178. The changes here are backward compatible with older Dataverse versions.

Copy link
Collaborator

@donsizemore donsizemore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just re-applied Jim's patch to the rebuilt dataversemetrics.odum.unc.edu (heh).

Not all Dataverse installations return JSON these days, so we need this PR for uniformity.

Copy link

@scolapasta scolapasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kcondon kcondon self-assigned this Apr 16, 2021
@kcondon kcondon merged commit c9f2326 into master Apr 16, 2021
@kcondon kcondon deleted the IQSS/59_use_accept_json_header branch April 16, 2021 14:27
@pdurbin pdurbin added this to the v0.2.8 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants