-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IP Groups: can no longer create datasets via SWORD #1354
Comments
@michbarsinai in this case user.getRequestMetadata() is null. I assume you're also ok with returning an empty set here, which is what I just did in this workaround so I can create a dataset via SWORD: 1aa570b Please advise. |
…f the incoming HttpServletRequest
The issue indeed was the missing request metadata. Added these at: 4a9e6f4. Over to @pdurbin for code review, validation that SWORD deposit works etc (on my machine it fails with:
) |
Just discussed with @pdurbin: The adding of IP groups effectively broke sword deposit . For the many operations of sword deposit, this particular one was fixed bu @michbarsinai change above so can be retested. Other sword related issues should be opened up as separate issues, for example #1360 |
Guys, it didn't break SWORD. Once the IP groups functionality is taken into consideration, SWORD is broken as it does not take them into account. Silent fails are still fails :-) |
Was able to create a dataset with Sword. Phil put in a workaround, not sure what the final resolution will be. |
We can no longer create datasets via SWORD, apparently due to the IP Groups feature being added for #700
Here's an example that worked last week:
curl --insecure --data-binary @scripts/search/tests/data/dataset-trees1.xml -H 'Content-Type: application/atom+xml' -u spruce:spruce https://localhost:8181/dvn/api/data-deposit/v1.1/swordv2/collection/dataverse/spruce
Now we are seeing the NullPointerException below.
@michbarsinai you said, "This may happen if the user does not have metadata with IP address. You can override this by returning an empty set if no IP address is present (at the site where the exception is thrown)" but I'm not sure what this means so I'm giving this ticket to you and marking it as critical.
The text was updated successfully, but these errors were encountered: